Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export EmptyValue symbol #1296

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

BrianHung
Copy link
Contributor

@BrianHung BrianHung commented Aug 2, 2023

Context

Exports EmptyValue.

How did you test your changes?

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Custom functions are unable to handle empty cell values. #1265
  2. Reverts Hide EmptyValue from public APIs #323

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba added the CLA signed Required for PR label Aug 3, 2023
@sequba sequba changed the base branch from master to develop August 3, 2023 13:21
@sequba sequba changed the title export EmptyValue symbol Export EmptyValue symbol Aug 3, 2023
Copy link
Contributor

@sequba sequba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please, add a changelog entry, and we'll be ready to merge it.

@BrianHung BrianHung requested a review from sequba August 5, 2023 05:21
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1296 (84750a7) into develop (d076d1e) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1296   +/-   ##
========================================
  Coverage    97.20%   97.20%           
========================================
  Files          167      167           
  Lines        14295    14299    +4     
  Branches      3064     3064           
========================================
+ Hits         13895    13899    +4     
  Misses         395      395           
  Partials         5        5           
Files Changed Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/interpreter/index.ts 100.00% <100.00%> (ø)
src/interpreter/plugin/MatrixPlugin.ts 97.88% <100.00%> (ø)

@sequba sequba merged commit 276f731 into handsontable:develop Aug 8, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed Required for PR Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom functions are unable to handle empty cell values.
3 participants