Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry about PV function to the list of runtime differences #1319

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Oct 3, 2023

Context

PV function with periods = 0 is an edge case in which Excel and Sheets give different results. I added information about this inconsistency to our list of runtime differences in the docs. HyperFormula behaves in the same way as Excel for this edge case.

How did you test your changes?

local docs buid

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1249

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Oct 3, 2023
@sequba sequba requested a review from evanSe October 3, 2023 16:49
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Performance comparison of head (02b401f) vs base (cc5a59f)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 776.91 | 771.34 |  -0.72%
                                      Sheet B |  265.1 | 263.94 |  -0.44%
                                      Sheet T |  226.3 | 227.34 |  +0.46%
                                Column ranges | 855.91 |  852.9 |  -0.35%
Sheet A:  change value, add/remove row/column |     58 |     59 |  +1.72%
 Sheet B: change value, add/remove row/column |    416 |    433 |  +4.09%
                   Column ranges - add column |    242 |    239 |  -1.24%
                Column ranges - without batch |    800 |    930 | +16.25%
                        Column ranges - batch |    159 |    156 |  -1.89%

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1319 (02b401f) into develop (cc5a59f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1319   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14422    14422           
  Branches      3018     3018           
========================================
  Hits         14029    14029           
  Misses         393      393           

@sequba sequba merged commit a008c1d into develop Oct 4, 2023
23 checks passed
@sequba sequba deleted the feature/issue-1249 branch October 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility: Different result for PV() when rate === -1 and periods === 0
2 participants