-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes edges map graph #1329
Closed
Closed
Nodes edges map graph #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 97.25% 97.20% -0.06%
==========================================
Files 169 169
Lines 14408 14430 +22
Branches 3076 3019 -57
==========================================
+ Hits 14012 14026 +14
- Misses 391 404 +13
+ Partials 5 0 -5
|
Performance before
Performance after
|
I assume you closed this PR because of the results of the performance testing. For your information: we recently refactored the dependency graph to use simple arrays instead of Maps and Sets in order to improve performance (#1293). For most real-world use cases simple arrays seem to be faster ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Uses maps and sets for dependency graph to hold node ids. Faster to query for adjacent nodes, and easier to delete edges and nodes.
How did you test your changes?
Internal refactor. PR should pass
graph.spec.ts
.Types of changes
Related issues:
Checklist: