Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: document apostrophe as an explicit string literal trigger #1334

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Nov 9, 2023

Context

Added section 'Forcing the string value type' to the 'Types of values' guide.

Unit tests have been added in #1161

How did you test your changes?

  • unit tests pass
  • local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #960

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba linked an issue Nov 9, 2023 that may be closed by this pull request
5 tasks
@sequba sequba self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Performance comparison of head (6d3111d) vs base (8a4bc46)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 558.96 |  559.3 | +0.06%
                                      Sheet B | 182.54 | 188.13 | +3.06%
                                      Sheet T | 163.42 |  162.8 | -0.38%
                                Column ranges |  565.6 | 567.55 | +0.34%
Sheet A:  change value, add/remove row/column |     41 |     42 | +2.44%
 Sheet B: change value, add/remove row/column |    292 |    304 | +4.11%
                   Column ranges - add column |    150 |    157 | +4.67%
                Column ranges - without batch |    584 |    599 | +2.57%
                        Column ranges - batch |     90 |     94 | +4.44%

@sequba sequba requested a review from evanSe November 9, 2023 16:48
docs/guide/types-of-values.md Outdated Show resolved Hide resolved
docs/guide/types-of-values.md Outdated Show resolved Hide resolved
@sequba sequba requested a review from evanSe December 19, 2023 10:48
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #1334 (6d3111d) into develop (8a4bc46) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1334   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files          169      169           
  Lines        14423    14423           
  Branches      3023     3023           
========================================
  Hits         14043    14043           
  Misses         380      380           

@sequba sequba merged commit e8729b6 into develop Dec 19, 2023
23 checks passed
@sequba sequba deleted the feature/issue-960 branch December 19, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: document apostrophe as an explicit string literal trigger
2 participants