Fix scroll to quoted message Wunderfitz#566

handydevcom · May 14, 2024 · 4b471e1 · 4b471e1
1 parent 6cae9b4
commit 4b471e1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/qml/pages/ChatPage.qml b/qml/pages/ChatPage.qml
@@ -417,7 +417,7 @@ Page {
             chatPage.messageIdToScrollTo = messageId
         }
         if (chatPage.messageIdToScrollTo && chatPage.messageIdToScrollTo != "") {
-            var index = chatModel.getMessageIndex(chatPage.messageIdToScrollTo);
+            var index = chatModel.getDisplayedMessageIndex(chatPage.messageIdToScrollTo);
             if(index !== -1) {
                 chatPage.messageIdToScrollTo = "";
                 chatView.scrollToIndex(index);

diff --git a/src/chatmodel.cpp b/src/chatmodel.cpp
@@ -472,13 +472,23 @@ QVariantMap ChatModel::getMessage(int index)
     return QVariantMap();
 }
 
-int ChatModel::getMessageIndex(qlonglong messageId)
+int ChatModel::getDisplayedMessageIndex(qlonglong messageId)
 {
     if (messages.size() == 0) {
         return -1;
     }
     if (messageIndexMap.contains(messageId)) {
-        return messageIndexMap.value(messageId);
+        int rawIndex = messageIndexMap.value(messageId);
+        // We need to substract number of albums which are shown before this item, because that's the index it's displayed on screen at.
+        int realIndex = rawIndex;
+        for(int i = 0; i < rawIndex; i++) {
+            MessageData *message = messages.at(i);
+            if(message->albumMessageIds.count() > 0) {
+                realIndex -= (message->albumMessageIds.count() - 1);
+            }
+        }
+
+        return realIndex;
     }
     return -1;
 }

diff --git a/src/chatmodel.h b/src/chatmodel.h
@@ -49,7 +49,7 @@ class ChatModel : public QAbstractListModel
     Q_INVOKABLE int getLastReadMessageIndex();
     Q_INVOKABLE void setSearchQuery(const QString newSearchQuery);
 
-    Q_INVOKABLE int getMessageIndex(qlonglong messageId);
+    Q_INVOKABLE int getDisplayedMessageIndex(qlonglong messageId);
     QVariantMap smallPhoto() const;
     qlonglong getChatId() const;