[#18] Implement halt system call #43

Lment · 2017-04-09T10:32:53Z

Implementation of halt system call, using function defined in init.h.
shutdown_power_off() is unavailable in our pintos.

hangpark · 2017-04-09T11:25:17Z

src/userprog/syscall.c

@@ -91,7 +92,7 @@ syscall_handler (struct intr_frame *f UNUSED)
 static void 
 syscall_halt (void)
 {
-
+  power_off();
 }


hangpark · 2017-04-09T11:48:55Z

src/userprog/syscall.c

@@ -91,7 +92,7 @@ syscall_handler (struct intr_frame *f UNUSED)
 static void 
 syscall_halt (void)
 {
-
+  power_off();


Writing comment above this would be better.

hangpark · 2017-04-09T12:56:02Z

src/userprog/syscall.c

@@ -88,10 +90,12 @@ syscall_handler (struct intr_frame *f UNUSED)
    }
 }

+/* This syscall terminates pintos. */


Please follow the format of other explanation comments.

hangpark · 2017-04-09T13:24:26Z

src/userprog/syscall.c

@@ -88,10 +90,12 @@ syscall_handler (struct intr_frame *f UNUSED)
    }
 }

+/* Terminate pintos by calling built-in command. */


whether calling built-in command or non-built-in command is not important. And other comments use terminates, not terminate I think. Check it.

/* Free the current process's resources. */ /* Create a minimal stack by mapping a zeroed page at the top of user virtual memory. */

/* Waits for thread TID to die and returns its exit status. /* Starts a new thread running a user program loaded from

@hangpark
In process.c, both appears. I didn't think much of it.
So you prefer -s on comments..? Then I'll follow it.

Anything would be ok, then. You can choose.

I would not use -s from now on then.

Ok. I'll follow too.

hangpark

Changing commit title to implement halt system call would be better.

hangpark

Implementation of halt system call, using function defined in init.h
This is your commit message.

Where is comma?
You should wrap paths, function names, file names, etc., with `.
threads/init.h is better than init.h.
Which function? Specify it.

hangpark · 2017-04-09T17:28:35Z

src/userprog/syscall.c

@@ -88,10 +90,12 @@ syscall_handler (struct intr_frame *f UNUSED)
    }
 }

+/* Terminate pintos by calling built-in command. */


You said you will use -s on verb. Why didn't this change yet? Also, by calling ~~~ is not needed I think.

I wrote 'would not use' them...

hangpark

Update to develop please.

Implementation of `halt ()` system call, using `power_off ()` defined in `threads/init.h`.

Lment self-assigned this Apr 9, 2017

Lment requested a review from hangpark April 9, 2017 10:37