Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokaMaker: Add error handling to .save_eqdsk() (failed tracing) #68

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hansec
Copy link
Owner

@hansec hansec commented Jul 11, 2024

This pull request adds error handling to OpenFUSIONToolkit.TokaMaker.TokaMaker.save_eqdsk()

Additionally, the following changes to the core code were made:

  • Update error reporting in TokaMaker.get_q() to report flux coordinate where tracing failed

This pull request does not modify any existing APIs or input file settings.

 - Update error reporting in `.get_q()` to report flux coordinate where tracing failed
@hansec hansec added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 53.2%. Comparing base (98c0492) to head (4deab85).

Files Patch % Lines
src/physics/grad_shaf_util.F90 0.0% 14 Missing ⚠️
src/python/OpenFUSIONToolkit/TokaMaker/_core.py 0.0% 4 Missing ⚠️
src/python/wrappers/tokamaker_f.F90 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #68     +/-   ##
=======================================
- Coverage   53.3%   53.2%   -0.1%     
=======================================
  Files        128     128             
  Lines      42330   42345     +15     
=======================================
  Hits       22563   22563             
- Misses     19767   19782     +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansec hansec merged commit 730f4b6 into main Jul 11, 2024
13 checks passed
@hansec hansec deleted the tMaker_eqdsk_err branch August 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant