Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error on Windows (WSL) due to carriage returns in git output #75

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

hansec
Copy link
Owner

@hansec hansec commented Aug 26, 2024

This pull request fixes a compile error that can occur on certain Windows (WSL) machines due to carriage returns in git output.

This pull request does not modify any APIs or input files.

@hansec hansec added the bug Something isn't working label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.7%. Comparing base (1789073) to head (dfc112f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #75   +/-   ##
=====================================
  Coverage   52.7%   52.7%           
=====================================
  Files        128     128           
  Lines      42787   42787           
=====================================
  Hits       22571   22571           
  Misses     20216   20216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansec hansec merged commit 66f38de into main Aug 28, 2024
13 checks passed
@hansec hansec deleted the Windows_git_CR branch August 28, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant