Fix loading pretrained-mm-projector errors under Deepspeed Zero3. #1250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fine-tuning stage of llava, if we apply deepspeed zero3, it will put placeholders in model parameters instead of initializing real ones.
As a result, the naive
load_state_dict
raises errors when the code tries to load the pretrained mm projector from somewhere likemm_projector.bin
.This PR solves this by detecting if deepspeed zero3 is applied by the
is_deepspeed_zero3_enabled()
from transformers, and wraps the loading code withdeepspeed.zero.GatheredParameters
to make it effective in that case.