Update clip_encoder.py for s^2 #1457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `super().__init__(vision_tower, args, delay_load)` will reult in `ValueError` as it would tell its parent class `CLIPVisionTower` to call `load_model` method and attemp to access `s2_scales` while the attribute is still to be defined yet. By calling `load_model` after `s2_scales` is defined can resolve this issue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
super().__init__(vision_tower, args, delay_load)will reult inValueErroras the parent classCLIPVisionTowerwould callload_modelmethod and attemp to accesss2_scaleswhile the attribute is still to be defined yet.By calling
load_modelafters2_scalesis defined in__init__can resolve this issue.