Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contained bug #6402

Merged
merged 12 commits into from
Oct 26, 2024
Merged

Contained bug #6402

merged 12 commits into from
Oct 26, 2024

Conversation

tadgh
Copy link
Collaborator

@tadgh tadgh commented Oct 24, 2024

  • Test
  • modify algorithm for server-assigned contained IDs.
  • Process contained resources which have a client-assigned ID before those that do not in a resource.
  • moved ContainedResources from the Parser, to the EncodeContext object, so we get one per resource processed.
    Closes Terser has odd behaviour  #6403

Copy link

github-actions bot commented Oct 24, 2024

Formatting check succeeded!

@tadgh tadgh changed the base branch from master to rel_7_6 October 25, 2024 03:33
@tadgh tadgh enabled auto-merge (squash) October 25, 2024 17:05
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rel_7_6@60ed1fd). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             rel_7_6    #6402   +/-   ##
==========================================
  Coverage           ?   83.53%           
  Complexity         ?    27770           
==========================================
  Files              ?     1738           
  Lines              ?   107467           
  Branches           ?    13493           
==========================================
  Hits               ?    89769           
  Misses             ?    11913           
  Partials           ?     5785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadgh tadgh merged commit e78a0b8 into rel_7_6 Oct 26, 2024
66 checks passed
@tadgh tadgh deleted the contained-test branch October 26, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terser has odd behaviour
3 participants