Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps and use travis templates #117

Merged
merged 5 commits into from
Aug 24, 2020
Merged

update deps and use travis templates #117

merged 5 commits into from
Aug 24, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 22, 2020

No description provided.

@geek
Copy link
Member

geek commented Aug 23, 2020

Looks like the message returned from redis changed, can probably update

expect(consoleMessage).to.contain('Redis server does not require a password, but a password was supplied');
to something like: "does not require a password, but a password was supplied"

@cjihrig cjihrig force-pushed the master branch 2 times, most recently from abebbab to 578f586 Compare August 23, 2020 21:13
This commit moves more of the redis setup into the docker-compose
file.
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 24, 2020

@geek I updated the test whose error message had changed. I also got rid of the Travis dependency on redis by pushing everything into the docker-compose. As a result, I ended up mocking the one Unix Domain Socket test because Docker didn't seem to allow the host and container to share the same UDS.

This commit updates the only test that uses Unix Domain Sockets
to connect to a mock Node.js server instead of a Redis container.
@lloydbenson
Copy link
Contributor

This is great work thanks so much @cjihrig.

@lloydbenson lloydbenson self-requested a review August 24, 2020 15:15
@cjihrig cjihrig merged commit 038bc68 into hapijs:master Aug 24, 2020
@cjihrig cjihrig added this to the 6.1.1 milestone Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants