Postgres sixteen version #1013
Merged
Postgres sixteen version #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From postgres version 16 onward it is necessary for exported background worker functions to be marked PGDLLEXPORT. Otherwise they are not findable by LookupBackgroundWorkerFunction(). Failing to mark healthcheck entry point functions as such leads to a miss functioning monitor as the child processes will fail to launch yet the monitor will be running. Adding the markings to previous postgres versions does not have any adverse symptoms. Hence this commit adds them unconditionally.
The structure member 'bgw_type' is used in various log messages within a postgres process. When undeclared the log messages are filled with random chars resulting to unparseable or broken messages. Additionally by setting 'bgw_type' it is possible to group all healthckeck workers in a process listing.
dimitri
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PGDLLEXPORT markings in exported bgworker functions
From postgres version 16 onward it is necessary for exported background worker
functions to be marked PGDLLEXPORT. Otherwise they are not findable by
LookupBackgroundWorkerFunction().
Failing to mark healthcheck entry point functions as such leads to a miss
functioning monitor as the child processes will fail to launch yet the monitor
will be running.
Adding the markings to previous postgres versions does not have any adverse
symptoms. Hence this commit adds them unconditionally.
While at it, improve the log messages by defining bgw_type.