Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we are using
snprintf
to make sure we don't overflow a buffer, wedon't actually check if the whole string was written in most cases. If this
would occur, this would cause very weird bugs and possibly buffer overflows
later in the code. This PR makes sure we actually check the result of sformat.
It uses macros to limit clutter on the callsite for an edge case that almost
certainly will not happen.