{WIP} Implement on_primary hooks. #958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimCitus
added
enhancement
dimitri
force-pushed
the
feature/on-primary-hooks
branch
from
fe50811
to
e82e3e1
Compare
This allows users of pg_auto_failover to setup their own scripts/actions to complement a failover. The hooks are run in a process that is separate from the main FSM, so as to prevent the system from making progress. As a result, it's not possible for the hooks to change how things are implemented in pg_auto_failover itself. The hook system also allows running a user-defined "service", which is a long running process or a deamon that belongs to pg_autoctl process tree. - [x] Implement a new internal service for running user-defined hooks - [ ] Implement pg_autoctl enable|disable run-hooks - [ ] Implement pg_autoctl create listener - [ ] Implement support for running script/commands (man system) - [ ] Add unit testing support for user-defined hooks - [ ] Document the new hook system, including tutorial - [ ] Add documentation examples covering pgbouncer as a hooked system
dimitri
force-pushed
the
feature/on-primary-hooks
branch
from
e82e3e1
to
66c05b9
Compare
|
This feature will be extremely valuable. Any thoughts on when we can expect this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of pg_auto_failover to setup their own scripts/actions to complement a failover. The hooks are run in a process that is separate from the main FSM, so as to prevent the system from making progress.
As a result, it's not possible for the hooks to change how things are implemented in pg_auto_failover itself.
The hook system also allows running a user-defined "service", which is a long running process or a deamon that belongs to pg_autoctl process tree.
Fixes #878.
Closes #573.
Closes #539.
Closes #508.
Fixes #490.
Fixes #440.
Fixes #427.