contrib/hbwin: Fixed dangling pointer access in WIN_DRAWBITMAP(). #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems sensible to fix this scope indeed. Though there remain other issues, and BMP is difficult (if possible at all) to handle securely. FWIW the commit 64dba82 adding this scoped variable also left an ancient FIXME comment in the wrong place inside this function. It's supposed to come before the |
* contrib/hbwin/win_bmp.c
! Fixed dangling pointer access (introduced in commit 64dba82) in
WIN_DRAWBITMAP().
tuffnatty
force-pushed
the
fix-dangling-pointer-access-in-hbwin
branch
from
912310f to
65d8018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-11-11 21:41 UTC+0100 Phil Krylov (phil a t krylov.eu)
! Fixed dangling pointer access (introduced in commit 64dba82) in
WIN_DRAWBITMAP().
--
@vszakats, you may be interested in this. I saw your comments about some GPF around this place.