Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect all __init__.py besides files starts with test #4

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

MortalHappiness
Copy link
Contributor

@MortalHappiness MortalHappiness commented Oct 24, 2023

FIS-1417
FIS-1418

Why need this change ? / Root Cause :

After discussion, we decided to discard mode selection and always obey .gitignore. Furthermore, we also want to scan __init__.py for other files besides filenames starting with test.

Changed Made :

  • Rewrite the logic to always obey .gitignore.

Test Scope / Change Impact :

Completely new tests

@MortalHappiness MortalHappiness requested a review from a team as a code owner October 24, 2023 09:35
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit d674f50.

♻️ This comment has been updated with latest results.

tests/test_missing.py Show resolved Hide resolved
src/missing.py Show resolved Hide resolved
src/missing.py Outdated Show resolved Hide resolved
@MortalHappiness MortalHappiness merged commit d47281d into main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants