Skip to content

Commit

Permalink
Fix datepicker type error (valor-software#6378)
Browse files Browse the repository at this point in the history
* fix(datepicker): fixed error on clearing datepicker input

* fix(datepicker): fix error on clearing datepicker input

* docs: add item about forking into contributing guide

Co-authored-by: Dmitry Yaroshenko <[email protected]>
Co-authored-by: Dmitriy Shekhovtsov <[email protected]>
  • Loading branch information
3 people authored Dec 23, 2021
1 parent a85b6eb commit 55f19ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:

* Search [GitHub](https://github.com/valor-software/ngx-bootstrap/pulls) for an open or closed PR
that relates to your submission. You don't want to duplicate effort.
* Create a fork from ngx-bootstrap repository as it is described in [GitHub docs](https://docs.github.com/en/get-started/quickstart/fork-a-repo#forking-a-repository)
* To build lib for development, follow [this manual](https://github.com/valor-software/ngx-bootstrap#how-to-build-lib-for-development)
* Make your changes in a new git branch:

Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/reducer/bs-datepicker.reducer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function bsDatepickerReducer(state: BsDatepickerState = initialDatepicker

if (Array.isArray(state.selectedTime)) {
const _time = state.selectedTime[0];
if (_time) {
if (newState.selectedDate && _time) {
copyTime(newState.selectedDate, _time);
}
}
Expand Down

0 comments on commit 55f19ba

Please sign in to comment.