optimize code of paging servlet

hardingadonis · Mar 1, 2024 · 11fbe10 · 11fbe10
1 parent 241e943
commit 11fbe10
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/main/java/io/hardingadonis/saledock/controller/management/product/ProductServlet.java b/src/main/java/io/hardingadonis/saledock/controller/management/product/ProductServlet.java
@@ -10,39 +10,33 @@
 
 @WebServlet(name = "ProductServlet", urlPatterns = {"/product"})
 public class ProductServlet extends HttpServlet {
+    final static int LIMIT = 10;
 
     @Override
     protected void doGet(HttpServletRequest request, HttpServletResponse response)
             throws ServletException, IOException {
         request.setCharacterEncoding("UTF-8");
         response.setContentType("text/html; charset=UTF-8");
 
-        List<Product> products = Singleton.productDAO.getAll();
-
         int page = 1;
-        int limit = 10;
-
         if (request.getParameter("page") != null) {
             try {
                 page = Integer.parseInt(request.getParameter("page"));
-
             } catch (Exception e) {
                 response.sendRedirect("./error-404");
                 return;
             }
         }
 
-        List<Product> list = Singleton.productDAO.pagination((page - 1) * limit, limit);
+        List<Product> list = Singleton.productDAO.pagination((page - 1) * LIMIT, LIMIT);
         Integer count = Singleton.productDAO.count();
-        int totalPage = Singleton.productDAO.totalPages(limit);
-
-        list.isEmpty();
+        int totalPage = Singleton.productDAO.totalPages(LIMIT);
 
         request.setAttribute("productList", list);
         request.setAttribute("currentPage", page);
         request.setAttribute("totalPage", totalPage);
         request.setAttribute("numOfPro", count);
-        request.setAttribute("limit", limit);
+        request.setAttribute("limit", LIMIT);
 
         request.setAttribute("page", "product");