-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support esm & typescript #90
base: main
Are you sure you want to change the base?
Conversation
CC @shuding |
cc @chearon |
I definitely think it would be great to have the JS parts written in TypeScript. I'm not sure about all of the rest. Since this library is framework-agnostic I wonder if the React stuff belongs in a separate demo repo. I can try to make a real review soon. |
@chearon Don't worry about react stuff which is just a playground. I have make this lib a monorepo and react stuff will not affect final bundle result of harfbuzzjs. What I do is just translate original example code to a vite-react demo repo. If needed, I am pleased to refine playground for better DX. |
Hi, there! This is a satori contributor, currently satori has a lot of issues releated to font where we use opentype.js to render font. We are looking for a better font renderer so that we can make satori better(see vercel/satori#83).
Based on bg above, I find this lib has following problems:
To make this lib a modern lib, i make this PR. Looking forward to your feedback~