refactor: support esm & typescript #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie1210
changed the title
|
CC @shuding |
|
cc @chearon |
|
I definitely think it would be great to have the JS parts written in TypeScript. I'm not sure about all of the rest. Since this library is framework-agnostic I wonder if the React stuff belongs in a separate demo repo. I can try to make a real review soon. |
|
@chearon Don't worry about react stuff which is just a playground. I have make this lib a monorepo and react stuff will not affect final bundle result of harfbuzzjs. What I do is just translate original example code to a vite-react demo repo. If needed, I am pleased to refine playground for better DX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there! This is a satori contributor, currently satori has a lot of issues releated to font where we use opentype.js to render font. We are looking for a better font renderer so that we can make satori better(see vercel/satori#83).
Based on bg above, I find this lib has following problems:
To make this lib a modern lib, i make this PR. Looking forward to your feedback~