Fix: Only apply avar table to the variation axis being set #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 3, 2024 16:41
There is an issue in Rustybuzz where calling set_variations which internally calls set_variation multiple time will cause the avar table to be applied to the same coordinate value multiple times. This causes the wrong values to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in Rustybuzz where calling
set_variationswhich internally callsset_variationmultiple time will cause the avar table to be applied to the same coordinate value multiple times. This causes the wrong values to be set.This is an attempt at a fix that by only applying the avar table to the coordinate currently being set.
Fixes harfbuzz/rustybuzz#136