Fixed tests.

consensus/quorum/quorom_test.go

@@ -629,7 +629,7 @@ func TestCIdentities_NthNextValidatorFailedEdgeCase2(t *testing.T) {
 	case <-done:
 		t.Error("Expected a timeout, but successfully calculated next leader")
 
-	case <-time.After(5 * time.Second):
+	case <-time.After(1 * time.Second):
 		t.Log("Test timed out, possible infinite loop")
 	}
 }

consensus/quorum/quorum.go

@@ -280,7 +280,7 @@ func (s *cIdentities) NthNextValidator(slotList shard.SlotList, pubKey *bls.Publ
 			Str("key", pubKey.Bytes.Hex()).
 			Msg("[NthNextHmy] pubKey not found")
 	}
-	for i := 0; i < len(slotList); i++ {
+	for {
 		numNodes := len(s.publicKeys)
 		idx = (idx + next) % numNodes
 		if publicToAddress[s.publicKeys[idx].Bytes] == publicToAddress[pubKey.Bytes] {
@@ -290,7 +290,6 @@ func (s *cIdentities) NthNextValidator(slotList shard.SlotList, pubKey *bls.Publ
 		}
 		return found, &s.publicKeys[idx]
 	}
-	return false, pubKey
 }
 
 func (s *cIdentities) NthNextHmy(instance shardingconfig.Instance, pubKey *bls.PublicKeyWrapper, next int) (bool, *bls.PublicKeyWrapper) {