Turn pprof default on with local saved files (#3894)

* Turn pprof default on with local saved files * [pprof] change interval from 600s to 3600s
harmony-one · Apr 5, 2023 · 78d26d7 · 78d26d7
1 parent 7d5eb9c
commit 78d26d7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/cmd/harmony/config_migrations_test.go b/cmd/harmony/config_migrations_test.go
@@ -281,7 +281,7 @@ Version = "1.0.4"
   Port = 9000
 
 [Pprof]
-  Enabled = false
+  Enabled = true
   ListenAddr = "127.0.0.1:6060"
 
 [RPCOpt]

diff --git a/cmd/harmony/config_test.go b/cmd/harmony/config_test.go
@@ -79,7 +79,7 @@ Version = "1.0.4"
   Port = 9000
 
 [Pprof]
-  Enabled = false
+  Enabled = true
   ListenAddr = "127.0.0.1:6060"
 
 [TxPool]

diff --git a/cmd/harmony/default.go b/cmd/harmony/default.go
@@ -87,11 +87,11 @@ var defaultConfig = harmonyconfig.HarmonyConfig{
 	},
 	Sync: getDefaultSyncConfig(defNetworkType),
 	Pprof: harmonyconfig.PprofConfig{
-		Enabled:            false,
+		Enabled:            true,
 		ListenAddr:         "127.0.0.1:6060",
 		Folder:             "./profiles",
-		ProfileNames:       []string{},
-		ProfileIntervals:   []int{600},
+		ProfileNames:       []string{"cpu", "heap", "goroutine"},
+		ProfileIntervals:   []int{3600},
 		ProfileDebugValues: []int{0},
 	},
 	Log: harmonyconfig.LogConfig{

diff --git a/cmd/harmony/flags_test.go b/cmd/harmony/flags_test.go
@@ -122,11 +122,11 @@ func TestHarmonyFlags(t *testing.T) {
 					LocalAccountsFile: "./.hmy/locals.txt",
 				},
 				Pprof: harmonyconfig.PprofConfig{
-					Enabled:            false,
+					Enabled:            true,
 					ListenAddr:         "127.0.0.1:6060",
 					Folder:             "./profiles",
-					ProfileNames:       []string{},
-					ProfileIntervals:   []int{600},
+					ProfileNames:       []string{"cpu", "heap", "goroutine"},
+					ProfileIntervals:   []int{3600},
 					ProfileDebugValues: []int{0},
 				},
 				Log: harmonyconfig.LogConfig{
@@ -1092,9 +1092,9 @@ func TestPprofFlags(t *testing.T) {
 			expConfig: defaultConfig.Pprof,
 		},
 		{
-			args: []string{"--pprof"},
+			args: []string{"--pprof=false"},
 			expConfig: harmonyconfig.PprofConfig{
-				Enabled:            true,
+				Enabled:            false,
 				ListenAddr:         defaultConfig.Pprof.ListenAddr,
 				Folder:             defaultConfig.Pprof.Folder,
 				ProfileNames:       defaultConfig.Pprof.ProfileNames,