Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/keep tests in separate repo for upgrade to 1.22 #4736

Merged
merged 20 commits into from
Aug 26, 2024

Conversation

mur-me
Copy link
Collaborator

@mur-me mur-me commented Aug 13, 2024

Issue

This PR has all the work from the #4722 PR, except commit that is moving tests to the repo

Test

Unit Test Coverage

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    YES|NO

  2. Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.

  3. Describe how the plan was tested.

  4. How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?

  5. What are the planned flag epoch numbers and their ETAs on Pangaea?

  6. What are the planned flag epoch numbers and their ETAs on mainnet?

    Note that this must be enough to cover baking period on Pangaea.

  7. What should node operators know about this planned change?

  8. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    YES|NO

  9. Does the existing node.sh continue to work with this change?

  10. What should node operators know about this change?

  11. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

@mur-me mur-me force-pushed the feat/keep_tests_in_separate_repo_upgrade_to_1.22 branch 3 times, most recently from 15218db to 79a245f Compare August 13, 2024 17:47
@mur-me mur-me requested review from GheisMohammadi and Frozen and removed request for GheisMohammadi August 15, 2024 15:22
@mur-me mur-me marked this pull request as ready for review August 15, 2024 15:22
cmd/bootnode/main.go Outdated Show resolved Hide resolved
internal/configs/node/network.go Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@Frozen Frozen mentioned this pull request Aug 19, 2024
@sophoah
Copy link
Contributor

sophoah commented Aug 20, 2024

@Frozen can you explain why we need core/genesis/go19.go, core/genesis/go20.go and why there isn't something for go 1.22 ?

@sophoah
Copy link
Contributor

sophoah commented Aug 20, 2024

@Frozen should we also update : api/service/legacysync/downloader/Proto.Dockerfile ? the dockerfile was added in #4427

@mur-me there is a few instances of 1.19, please help update https://github.com/search?q=repo%3Aharmony-one%2Fharmony+1.19&type=code

@mur-me mur-me force-pushed the feat/keep_tests_in_separate_repo_upgrade_to_1.22 branch from 75f5b7d to 1e2179d Compare August 22, 2024 14:13
@mur-me mur-me force-pushed the feat/keep_tests_in_separate_repo_upgrade_to_1.22 branch from 1e2179d to 821698d Compare August 22, 2024 14:37
@Frozen
Copy link
Contributor

Frozen commented Aug 22, 2024

@Frozen can you explain why we need core/genesis/go19.go, core/genesis/go20.go and why there isn't something for go 1.22 ?

Changed to 1.22

@Frozen
Copy link
Contributor

Frozen commented Aug 23, 2024

@Frozen should we also update : api/service/legacysync/downloader/Proto.Dockerfile ? the dockerfile was added in #4427

@mur-me there is a few instances of 1.19, please help update https://github.com/search?q=repo%3Aharmony-one%2Fharmony+1.19&type=code

Proto.Dockerfile already updated

@sophoah
Copy link
Contributor

sophoah commented Aug 23, 2024

see detail test #4722 (comment)

@sophoah sophoah merged commit c44c2ea into dev Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants