Skip to content

Commit

Permalink
Initial fixups
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Carrion authored Oct 7, 2022
2 parents ce3fcd5 + 893faae commit acc76b6
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 6 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
## Related Tasks

Does this PR relate to other tasks?

## Depends on

Are there any other PRs that need to be merged first?

## What

What changes have been made within this PR?

## Why

Why are we submitting this PR? What is the context, engineering and business goals being satisfied by this PR?

## Concerns

This section is optional, however if you have any concerns or questions regarding aspects of the PR, they can be included here. Including the concerns in this section ensures that they can be discussed as a part of the PR review.

## Notes

This section is also optional and should include anything else that you would like to discuss in the PR review that is not captured elsewhere.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ RUN apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# Docker daemon entrypoint
ADD ./dockerd-entrypoint.sh /usr/local/bin
ADD ./entrypoint.sh /usr/local/bin

# Prepare rootless user
RUN set -ex \
Expand All @@ -47,5 +47,5 @@ RUN set -ex \
VOLUME /home/rootless/.local/share/docker

EXPOSE 2375
ENTRYPOINT ["/usr/local/bin/dockerd-entrypoint.sh"]
ENTRYPOINT ["/usr/local/bin/entrypoint.sh"]
CMD []
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.DEFAULT_GOAL := help
IMAGE_NAME := cobalt-rootless-nvidia-dind
IMAGE_NAME := harrisonai/cobalt-rootless-nvidia-dind

## build: build the docker image
build:
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The image is based on the `debian:bullseye-slim` and incorperates these major co
Launching from the CLI:

```bash
docker run --rm -it --cap-add "SYS_ADMIN" cobalt-rootless-nvidia-dind:latest
docker run --rm -it --cap-add "SYS_ADMIN" harrisonai/cobalt-rootless-nvidia-dind
```

As a Kubernetes deployment:
Expand All @@ -51,8 +51,8 @@ spec:
app: dind
spec:
containers:
- name: docker
image: cobalt-rootless-nvidia-dind:latest
- name: dind
image: harrisonai/cobalt-rootless-nvidia-dind:latest
imagePullPolicy: Always
resources:
requests:
Expand Down
File renamed without changes.

0 comments on commit acc76b6

Please sign in to comment.