Skip to content

Commit

Permalink
receive: mark too-far-in-future flag as non-experimental (thanos-io#7707
Browse files Browse the repository at this point in the history
)

Signed-off-by: Michael Hoffmann <[email protected]>
  • Loading branch information
MichaHoffmann authored Sep 9, 2024
1 parent 27412d2 commit 153607f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
3 changes: 3 additions & 0 deletions .mdox.validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ validators:
type: 'ignore'
- regex: 'outshift\.cisco\.com\/blog\/multi-cluster-monitoring'
type: 'ignore'
# Expired certificate
- regex: 'bestpractices\.coreinfrastructure\.org\/projects\/3048'
type: 'ignore'
2 changes: 1 addition & 1 deletion cmd/thanos/receive.go
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ func (rc *receiveConfig) registerFlag(cmd extkingpin.FlagClause) {
rc.tsdbMaxBlockDuration = extkingpin.ModelDuration(cmd.Flag("tsdb.max-block-duration", "Max duration for local TSDB blocks").Default("2h").Hidden())

rc.tsdbTooFarInFutureTimeWindow = extkingpin.ModelDuration(cmd.Flag("tsdb.too-far-in-future.time-window",
"[EXPERIMENTAL] Configures the allowed time window for ingesting samples too far in the future. Disabled (0s) by default"+
"Configures the allowed time window for ingesting samples too far in the future. Disabled (0s) by default"+
"Please note enable this flag will reject samples in the future of receive local NTP time + configured duration due to clock skew in remote write clients.",
).Default("0s"))

Expand Down
13 changes: 6 additions & 7 deletions docs/components/receive.md
Original file line number Diff line number Diff line change
Expand Up @@ -540,13 +540,12 @@ Flags:
section in the Receive documentation:
https://thanos.io/tip/components/receive.md/#tenant-lifecycle-management
--tsdb.too-far-in-future.time-window=0s
[EXPERIMENTAL] Configures the allowed time
window for ingesting samples too far in the
future. Disabled (0s) by defaultPlease note
enable this flag will reject samples in the
future of receive local NTP time + configured
duration due to clock skew in remote write
clients.
Configures the allowed time window for
ingesting samples too far in the future.
Disabled (0s) by defaultPlease note enable
this flag will reject samples in the future of
receive local NTP time + configured duration
due to clock skew in remote write clients.
--tsdb.wal-compression Compress the tsdb WAL.
--version Show application version.
Expand Down

0 comments on commit 153607f

Please sign in to comment.