-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Python libraries to work with current Scala libraries in dataframes #113
base: master
Are you sure you want to change the base?
Conversation
… to date Scala classes.
Update Python libraries to reflect Scala changes
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
===========================================
+ Coverage 76.7% 89.41% +12.71%
===========================================
Files 42 48 +6
Lines 1395 1550 +155
Branches 103 106 +3
===========================================
+ Hits 1070 1386 +316
+ Misses 325 164 -161
Continue to review full report at Codecov.
|
@stevebuckingham , were you able to test this on a cluster? Does joins etc on a distributed data frame work in python? Or are more changes needed to fix the python scripts? |
sbt/sbt clean test is showing me a compilation failure in the python module: Listing '/Users/kernelfish/projects/magellan/python'... |
I'll update that - I've been compiling on 2.7 and so that is valid. I'll import print from future and update the cost. I've managed within joins between points and polygons but I am having a problem getting intersect to work with polyline and polygon (which I think it should looking at the Scala code). So I suggest you reject this pull request and I can submit a new one when I fox both of the above. |
Fix PySpark Support
Using point, polygon and polyline types in PySpark was broken due to changes in the Scala libraries, the references now required and how the types were being serialized and deserialized.
These changes are to re-enable dataframe functionality in the Python libraries.