Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading Null Shapes #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kd35a
Copy link

@kd35a kd35a commented Jul 3, 2018

Content of the test_null shapefile:

wkt_geom NAME (10)
Point (3 3) has geom
NULL null geom

@codecov-io
Copy link

Codecov Report

Merging #225 into master will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   90.16%   90.01%   -0.15%     
==========================================
  Files          52       54       +2     
  Lines        1789     1803      +14     
  Branches      124      123       -1     
==========================================
+ Hits         1613     1623      +10     
- Misses        176      180       +4
Impacted Files Coverage Δ
src/main/scala/magellan/Shape.scala 66.66% <ø> (+8.13%) ⬆️
src/main/scala/magellan/io/ShapeReader.scala 92.3% <100%> (+1.92%) ⬆️
src/main/scala/magellan/NullShape.scala 37.5% <37.5%> (ø)
...cala/org/apache/spark/sql/types/NullShapeUDT.scala 54.54% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9021e...737fb3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants