Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniel/add secrets manager #5

Merged

Conversation

Daniel-Han-Yang
Copy link
Contributor

@Daniel-Han-Yang Daniel-Han-Yang commented Sep 8, 2021

  1. Added SM Module with unit test & docu, only supports ssh keys at the moment not HTTPS Personal Access token. Has additional config params that can be passed into the step file
  2. Updated docker image to incorporate ssh-agent and ps command for testing
  3. Updated actual sample git key for testing
  4. Renamed environment.bats to run.bats which contains test for both environment and pre-exit hook, I've placed tests for both hooks together as the BATs test will not terminate if the ssh-agent continues to run Stuck on the last test of each file sstephenson/bats#80
    Hence, used pre-exit hook to ensure ssh-agent termination

@Daniel-Han-Yang Daniel-Han-Yang marked this pull request as draft September 8, 2021 04:10
@Daniel-Han-Yang Daniel-Han-Yang marked this pull request as ready for review September 8, 2021 22:27
@harshadbhatia harshadbhatia merged commit c1b19c1 into harshadbhatia:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants