Add retries to the individual streaming of files from zoom to s3 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lbjay
commented
Jul 15, 2024
lbjay
commented
- added tenacity (retry library) to function requirements
- failed files will be retried up to 5 times with a 2m wait in between
rute-santos
reviewed
Jul 15, 2024
|
Hi @lbjay I saw a few recommendations for preventing chunk transfer latency timeouts by adding the "tcp_keepalive=True" to the boto3 client. The default is false. I added notes on the ZIP-93 ticket. In summary: Consider changing That param is available in the version of boto3 used in this repo (1.26.142) https://github.com/boto/boto3/blob/1.26.142/docs/source/guide/configuration.rst#tcp_keepalive Here is an example of ensuing the param is supported https://github.com/brightbock/cloudwatch-logs-tag/blob/main/src/lambda.py#L192-L201 |
lbjay
force-pushed
the
f/ZIP-92-retry-file-downloading
branch
from
4095166
to
f65d453
Compare
- added tenacity (retry library) to function requirements - failed files will be retried up to 5 times with a 2m wait in between set `tcp_keepalive=True` for the boto3 s3 client this seems like a smart thing to do anyway, even though the connection issues that are motivating the retries are on the zoom side. See: https://www.miketheman.net/2022/10/04/reduce-aws-lambda-latencies-with-keep-alive-in-python/
lbjay
force-pushed
the
f/ZIP-92-retry-file-downloading
branch
from
f65d453
to
8b8d04b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.