This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Update Elasticsearch #2186
Merged
Update Elasticsearch #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensteinberg
requested review from
rebeccacremona
and removed request for
a team
|
Looks like changes made to make CAP export happy blew this up, but I don't think it matters? |
|
I'm looking into why the last updated rewrite isn't working. |
|
last_updated is fine, the problem is with date_added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2186 +/- ##
========================================
Coverage 63.51% 63.51%
========================================
Files 107 107
Lines 11746 11746
========================================
Hits 7460 7460
Misses 4286 4286 ☔ View full report in Codecov by Sentry. |
|
Ah, nice catch! In case others in the future are looking: that 23-12-05 date is simply the last time these files were generated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.elastic.co/guide/en/elasticsearch/reference/7.17/release-notes-7.17.16.html