import correct links #109
Draft
import correct links #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Cool, getting there! These are screenshots from my machine. DesktopHere's https://opencasebook.org/ at desktop size: and here's this PR at desktop size: Looks like there's some centering CSS to copy over, and extra space at the bottom. I think it might also want some more padding to separate the footer from the content? TabletHere's tablet-sized of https://opencasebook.org/ and this tablet-sized: Looks like the same centering css, plus the right-side content is bottom-aligned. MobileHere's mobile-sized of https://opencasebook.org/ and mobile-sized of this PR: Looks like all the nav disappears! Oh CSS. |
rebeccacremona
requested changes
Sep 29, 2022
There was a problem hiding this comment.
(Whoops, I accidentally posted review comments separately: see #109 (comment))
|
closing for now -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.