Merge pull request #2043 from bensteinberg/image-uuid

Suppress error for non-UUID in image route
harvard-lil · Mar 20, 2024 · e997b79 · e997b79
2 parents 4a6dabd + c3c883e
commit e997b79
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/web/main/views.py b/web/main/views.py
@@ -3280,5 +3280,10 @@ def view_image(request, image_uuid):
     Redirect to S3 with temp creds.
 
     """
-    saved_image = get_object_or_404(SavedImage.objects.filter(external_id=image_uuid))
-    return redirect(saved_image.image.url)
+    try:
+        assert uuid.UUID(image_uuid)
+        saved_image = get_object_or_404(SavedImage.objects.filter(external_id=image_uuid))
+        return redirect(saved_image.image.url)
+    except ValueError:
+        # image_uuid is not a UUID
+        raise Http404