Disable export of sections and resources #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
bensteinberg
approved these changes
Oct 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2033 +/- ##
===========================================
- Coverage 76.59% 76.53% -0.06%
===========================================
Files 64 64
Lines 7066 7066
===========================================
- Hits 5412 5408 -4
- Misses 1654 1658 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ENG-300 and ENG-414.
DOCX export of sections is sometimes not coming out right: headings are sometimes displayed in odd and misleading locations.
We believe it's something about reference.docx, some kind of absolute positioning gone wrong... but we aren't sure.
We don't love this but... for now, disable the exporting of individual sections and resources so that people don't encounter mixed up exports: they can always export the entire casebook, and delete the pages they don't need.