Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore playwright; upgrade black #2045

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

bensteinberg
Copy link
Contributor

This PR restores playwright to requirements.in, as we need it for functional tests; it also unpins and upgrades black and lets it make some changes.

https://github.com/psf/black/blob/main/CHANGES.md#2430

@bensteinberg bensteinberg requested a review from a team as a code owner March 21, 2024 14:30
@bensteinberg bensteinberg requested review from teovin and rebeccacremona and removed request for a team and teovin March 21, 2024 14:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.89%. Comparing base (ab56c04) to head (6ff3ac7).

Files Patch % Lines
web/main/legal_document_sources.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2045   +/-   ##
========================================
  Coverage    76.89%   76.89%           
========================================
  Files           60       60           
  Lines         6999     6999           
========================================
  Hits          5382     5382           
  Misses        1617     1617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, does this mean the functional tests aren't currently run by Github Actions? Interesting, I didn't realize that.

@bensteinberg
Copy link
Contributor Author

Hmmm, does this mean the functional tests aren't currently run by Github Actions? Interesting, I didn't realize that.

I think they are running!

@rebeccacremona
Copy link
Contributor

rebeccacremona commented Mar 25, 2024

I must be confused. If playwright is necessary for functional tests, and functional tests are run in Github Actions, and we removed playwright in an earlier PR... I would have expected to see the tests fail. Since we didn't... I'm confused.

@bensteinberg
Copy link
Contributor Author

Could playwright be built in to the runner?

@bensteinberg bensteinberg merged commit dbe8a91 into harvard-lil:develop Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants