Check targetUrlResolved against PRIVATE_BY_POLICY_DOMAINS
#3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3405 +/- ##
===========================================
+ Coverage 68.57% 68.65% +0.08%
===========================================
Files 53 53
Lines 7229 7233 +4
===========================================
+ Hits 4957 4966 +9
+ Misses 2272 2267 -5
☔ View full report in Codecov by Sentry. |
bensteinberg
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3392, we implemented a new policy for when to make Perma Links private: we maintain a list of domains to check against.
At the time, when capturing with Scoop, it was only possible for Perma to check the target URL.
As of Scoop 0.5.5, added to the Scoop API recently, we can now also see the URL that the browser "lands on", after any redirects, and check that too.
This PR does so.
See ENG-352.
Note: I spent a lot of time yesterday trying to add a test for this, experimenting with 3 approaches, none of which worked in all circumstances, and all of which were intricate. For a feature of this importance.... I think it is more appropriate to leave it untested. I'm happy to say more, if people are curious.