Tweak playback tray #3412
Merged
Tweak playback tray #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
matteocargnelutti
and removed request for
a team
rebeccacremona
force-pushed
the
tweak-tray
branch
from
c206407 to
13a158b
Compare
rebeccacremona
requested review from
bensteinberg and
clare-stanton
and removed request for
matteocargnelutti
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3412 +/- ##
========================================
Coverage 68.65% 68.65%
========================================
Files 53 53
Lines 7233 7233
========================================
Hits 4966 4966
Misses 2267 2267 ☔ View full report in Codecov by Sentry. |
bensteinberg
approved these changes
Oct 24, 2023
clare-stanton
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ENG-346 and ENG-301.
This PR does two closely-related, minor things.
a) As per ENG-346, it rewords the admin-only field in the playback tray stating whether a given Perma Link was captured by Perma, captured by Scoop, or uploaded by a user:
b) As per ENG-301, it displays a "Source: User Upload" field to non-staff, too, when that is the case: