Alert if something goes wrong with the Internet Archive task count #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
bensteinberg
approved these changes
Oct 25, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3413 +/- ##
===========================================
- Coverage 68.65% 68.62% -0.03%
===========================================
Files 53 53
Lines 7233 7236 +3
===========================================
Hits 4966 4966
- Misses 2267 2270 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-417
Something got scrambled, back in July, with Perma's internal record of how many Internet Archive tasks we currently have in flight: we think things got out-of-whack during a phased reboot of the workers.
Our records ended up in a state where, we thought we had more tasks in flight than is permitted, and so, we refrained from making any more uploads since.
We don't think this will happen again, because of a change in strategy: we will now go into maintenance mode before making changes like this.
But, this PR adds another level of safety: if we get into the same situation again, the upload task will now log to the error log.