Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest Scoop REST API in dev and tests #3426

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

rebeccacremona
Copy link
Contributor

I am not positive the CI move will work... If it doesn't, I will back out that change and address a bit later.

@rebeccacremona rebeccacremona requested a review from a team as a code owner November 1, 2023 16:05
@rebeccacremona rebeccacremona requested review from kilbergr and removed request for a team November 1, 2023 16:05
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91441d9) 68.75% compared to head (275943f) 64.57%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3426      +/-   ##
===========================================
- Coverage    68.75%   64.57%   -4.19%     
===========================================
  Files           53       53              
  Lines         7319     7319              
===========================================
- Hits          5032     4726     -306     
- Misses        2287     2593     +306     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebeccacremona
Copy link
Contributor Author

Hooray! It worked!

Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@rebeccacremona rebeccacremona removed the request for review from kilbergr November 1, 2023 16:24
@rebeccacremona rebeccacremona merged commit 2452363 into harvard-lil:develop Nov 1, 2023
2 checks passed
@rebeccacremona rebeccacremona deleted the update-scoop branch November 13, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants