Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade playwright #379

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

teovin
Copy link
Contributor

@teovin teovin commented Nov 19, 2024

@teovin teovin requested a review from bensteinberg November 19, 2024 15:59
Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note

Breaking: channels chrome, msedge and similar switch to new headless

but microsoft/playwright#33566 says

No action needed if you are not using browser channels.

and I think we are not using browser channels.

@teovin teovin merged commit f2e3167 into harvard-lil:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants