Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement idle-tranche strategy apy #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement idle-tranche strategy apy #229

wants to merge 3 commits into from

Conversation

hottyage
Copy link
Contributor

No description provided.

CryptJS13
CryptJS13 reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@CryptJS13 CryptJS13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on naming, to keep things general and consistent.

data/mainnet/addresses.json Outdated Show resolved Hide resolved
data/mainnet/pools.js Outdated Show resolved Hide resolved
data/mainnet/tokens.js Outdated Show resolved Hide resolved
data/mainnet/tokens.js Outdated Show resolved Hide resolved
data/mainnet/tokens.js Outdated Show resolved Hide resolved
data/mainnet/tokens.js Outdated Show resolved Hide resolved
@CryptJS13
Copy link
Contributor

@tommy4241 Hey, few comments:

  • When I run this locally I get an APY estimation of ~2.5%, while Idle's website is showing 6.2%, so there seems to be some kind of error in the calculation.
  • This strategy actually has a profit sharing fee of 15%, not 30%, so please alter that in the calculation.
  • There are conflicts with your PR and the master branch, please resolve them so we can merge when everything is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryptJS13 CryptJS13 CryptJS13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hottyage @CryptJS13