-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(1inch): add generic DAI_X base strategy and implement DAI_LDO #52
base: master
Are you sure you want to change the base?
feat(1inch): add generic DAI_X base strategy and implement DAI_LDO #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Liquidations for both 1INCH and stETH can be done through 1INCH. See the discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright looks good! 1 minor comment, which is not critical at all, would just make it more homogeneous with the rest of the repo.
Thanks for the work on this! I guess for the future we could look into making it even more general by not assuming DAI as token0, but leaving that open. We'll see if another 1INCH farm arises, this for now seems good to go for me. @breadforthepeople @bergben
Yes sounds great. I didn't want to spend any more time on this currently for such a generic baseStrategy because rewards only last until 24th October and also for my learning curve it helped to do a somewhat half generic baseStrategy first before going all the way. Great learnings though, thank you! |
Great to hear, you seem to be picking all this up very quickly, so that's very nice to see! As for the strategy actually getting shipped, I'm not 100% sure it's gonna be worth it with the rewards ending is less than 3 weeks. Might not be fair to users to offer it, as it's gonna be near impossible to earn back the gas fees for depositing/withdrawing, but maybe it's just fine if we can get it released today before emissions. But @breadforthepeople will have to weigh in on that. At least it was a useful learning experience! :) |
@breadforthepeople @Cryo45 I think this can be closed, we can revisit when some new farming op shows up on 1INCH |
Implements new DAI_X base strategy for 1inch and implements dai-ldo strategy.
DAI-stETH Liquidity on 1inch:
1inch-ETH Liquidity on 1inch:
LDO-ETH Liquidity on sushi:
APY / APR:
Test output on block 13352188 (npx hardhat test ./test/1inch/dai-ldo.js):