NotionalV2 Strategy #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belbix
reviewed
Jun 23, 2022
| 0x8eae010b847722fa95e85dfc0113c19f46531a85595a4a8aeb38cb97657d35c4; | ||
| bytes32 internal constant _NTOKEN_UNDERLYING = 0xca1ad68fb46e1d177e14769fefa6ec6792476f949c8cd88042b7f02ed2f5d2e2; | ||
|
|
||
| address public constant weth = address(0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2); |
| IERC20(_nTokenUnderlying).safeApprove(_rewardPool, underlyingBalance); | ||
| } | ||
|
|
||
| Types.BalanceAction memory action = Types.BalanceAction( |
There was a problem hiding this comment.
better to use Type creations via JSON, make reviewer work a bit easy :)
| IBVault.FundManagement memory funds; | ||
| funds.sender = address(this); | ||
| funds.fromInternalBalance = false; | ||
| funds.recipient = address(uint160(address(this))); |
There was a problem hiding this comment.
We need it to cast address to payable address.
| address _underlying, | ||
| address _vault, | ||
| address _rewardPool, // always the notional proxy, could be constant, | ||
| address _bVault, |
| } | ||
|
|
||
| function investedUnderlyingBalance() public view returns (uint256) { | ||
| uint256 underlyingBalance = IERC20(underlying()).balanceOf(address(this)); |
| address _vault, | ||
| address _rewardPool, // always the notional proxy, could be constant, | ||
| address _bVault, | ||
| bytes32 _note2wethpid, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New strategy for Notional V2. We hold the
nTokensand claimNOTErewards and compound those rewards into morenTokens.The
nTokensare liquidity share token, users provide liquidity to the Notional and get back thenTokens. More informations aboutnTokenshere.The reward token of this strategy is
WETH. We swap theNOTErewards toWETHand then swapWETHto the underlying of thenTokento mint morenToken.Added the test outputs for ETH and DAI since the Notional receives native
ETHinstead ofWETH.Test outputs at blockNumber = 15003364: