Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) #76

ryanycw · 2022-09-14T15:50:16Z

Strategy for wstETH <> wETH pair with Aura.

During doHardWork(), all rewards (AURA and BAL) are liquidated to wETH, then deposited wETH into Balancer for Balancer Pool Token(BPT), and finally, deposit BPT back to Aura.

Before deploying the contract, the following steps are required.

Add liquidation path to Harvest's Balancer Dex.
Add liquidation path to UniversalLiquidatorRegistry.

  Mainnet Aura auraB-stETH-STABLE pool
Impersonating...
0xf00dD244228F51547f0563e60bCa65a30FBF5f7f
0x8627425d8B3c16d16683a1E1e17ff00A2596E05f
0x6a74649aCFD7822ae8Fb78463a9f2192752E5Aa2
Fetching Underlying at:  0x32296969Ef14EB0c6d29669C550D4a0449130230
Set Dex Complete: Pair 0
New Vault Deployed:  0xAa90b2376F602AE6630c9476555Cb58763FaB3C8
Strategy Deployed:  0x286B8DecD5ED79c962b2d8F4346CD97FF0E2C352
Strategy and vault added to Controller.
    Happy path
loop  0
collected!
old shareprice:  1000000000000000000
new shareprice:  1000000000000000000
growth:  1
instant APR: 0 %
instant APY: 0 %
loop  1
collected!
old shareprice:  1000000000000000000
new shareprice:  1000079246514824837
growth:  1.000079246514825
instant APR: 7.867593991819816 %
instant APY: 8.184450764031537 %
loop  2
collected!
old shareprice:  1000079246514824837
new shareprice:  1000158562174426140
growth:  1.0000793093746096
instant APR: 7.873834711245902 %
instant APY: 8.191201007099158 %
loop  3
collected!
old shareprice:  1000158562174426140
new shareprice:  1000237786081644364
growth:  1.000079211347295
instant APR: 7.864102559441494 %
instant APY: 8.180674456817627 %
loop  4
collected!
old shareprice:  1000237786081644364
new shareprice:  1000317015182501856
growth:  1.0000792102657587
instant APR: 7.863995184528159 %
instant APY: 8.180558322998754 %
loop  5
collected!
old shareprice:  1000317015182501856
new shareprice:  1000396249477187762
growth:  1.000079209184172
instant APR: 7.86388780458866 %
instant APY: 8.180442183860714 %
loop  6
collected!
old shareprice:  1000396249477187762
new shareprice:  1000417378959433511
growth:  1.0000211211130157
instant APR: 2.0969041001952426 %
instant APY: 2.1189821045831225 %
loop  7
collected!
old shareprice:  1000417378959433511
new shareprice:  1000506253626665503
growth:  1.000088837588292
instant APR: 8.81979576562216 %
instant APY: 9.21926742426371 %
loop  8
collected!
old shareprice:  1000506253626665503
new shareprice:  1000595134827908975
growth:  1.000088836227581
instant APR: 8.81966067424626 %
instant APY: 9.219119914194618 %
loop  9
collected!
old shareprice:  1000595134827908975
new shareprice:  1000684024878017431
growth:  1.0000888371800085
instant APR: 8.819755231245505 %
instant APY: 9.219223163622026 %
AURA before 0
AURA after  13849116903845850482
earned!
Overall APR: 7.673518322959379 %
Overall APY: 7.97473927879051 %
      ✔ Farmer should earn money (165376ms)


  1 passing (3m)

ryanycw · 2022-09-14T15:53:15Z

@CryptJS13 Thank you for the assistance, here is the first strategy for wstETH and wETH.

CryptJS13

Hey, looks pretty good in general! Thanks for the great work! Some comments on minor stuff and some convention that we use. Let me know if you have any questions about anything :)

CryptJS13 · 2022-09-15T12:20:09Z

contracts/strategies/aura/AuraStrategystETH.sol

+
+import "./base/AuraStrategyUL.sol";
+
+contract AuraStrategystETH is AuraStrategyUL {


For the implemented strategy contracts, we prefer to fill out all the values within this contract instead of inputting them with the initialisation. As you can see in other strategy contracts in this repository, the only fields generally open for input in the initializeStrategy function are _storage and _vault. All other values can be filled within this contract.

The reason is that there is additional room for error when we need to pass these values with the function call, and there is no reason for these values to change between development and testing and actual deployment.

With filling in these values also comes our naming convention, which would in this case be AuraStrategyMainnet_stETH. Mainnet denoting that the implementation contains the values for Mainnet deployment. We don't really develop for any testnets, but we kept the convention this way anyways.

So please include all the values within this contract and let me know if you have any questions about this :)

CryptJS13 · 2022-09-15T12:24:34Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+    address _depositReceipt;
+    (_lpt,_depositReceipt,,,,) = IAuraBooster(booster).poolInfo(_auraPoolID);
+    require(_lpt == underlying(), "Pool Info does not match underlying");
+    require(1 < _poolAssets.length && _poolAssets.length < 5, "_nTokens should be 2, 3 or 4");


I don't think there's a need for this check with Balancer. We had it for Curve, as we did not have interface contracts added for other amounts of tokens in the pool. For Balancer I don't think it matters, as we don't need to import different interfaces.

CryptJS13 · 2022-09-15T12:34:15Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+      // if the token is the rewardToken then there won't be a path defined because liquidation is not necessary,
+      // but we still have to make sure that the toHodl part is executed.
+      if (rewardBalance == 0 || 
+          (storedLiquidationDexes[token][rewardToken()].length < 1) && 


If a certain stored variable, like rewardToken() is called more than once within the execution scope, it is more gas efficient to pull it from storage to local memory only once and keep it local for the remainder of the scope. So in this case it would be most efficient to, at the start of this function put address _rewardToken = rewardToken() and replace all other cases of rewardToken() with _rewardToken. Let me know if anything is unclear.

And of course the same goes for any other variable that is stored and used in a similar way

CryptJS13 · 2022-09-15T12:47:13Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+  function partialWithdrawalRewardPool(uint256 amount) 
+    internal 
+  {
+    IAuraBaseRewardPool(rewardPool()).withdraw(amount, false);  //don't claim rewards at this point


Can we use withdrawAndUnwrap on the BaseRewardPool to make the withdrawal in a single step? That would also make the depositReceipt variable obsolete.

CryptJS13 · 2022-09-15T12:48:11Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+  {
+    uint256 stakedBalance = _rewardPoolBalance();
+    if (stakedBalance != 0) {
+        IAuraBaseRewardPool(rewardPool()).withdrawAll(false); //don't claim rewards


Same here, but use withdrawAllAndUnwrap

CryptJS13 · 2022-09-15T12:48:34Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+  {
+      uint256 stakedBalance = _rewardPoolBalance();
+      if (stakedBalance != 0) {
+          IAuraBaseRewardPool(rewardPool()).withdrawAll(true);


Same, use withdrawAllAndUnwrap

CryptJS13 · 2022-09-15T12:49:20Z

contracts/strategies/aura/base/AuraStrategyUL.sol

+  uint256 public constant hodlRatioBase = 10000;
+  address[] public poolAssets;
+  address[] public rewardTokens;
+  bytes32[] public dexes;


is this used?

CryptJS13 · 2022-09-15T12:51:10Z

test/aura/import/stETH.config.json

@@ -0,0 +1,32 @@
+{


This is pretty cool and useful :)

Quite some of the parameters won't be needed in the test as we add them to the strategy contract directly, but I think the config file is still useful. Thanks!

CryptJS13 · 2022-09-15T12:54:19Z

test/aura/stETH.js

+      "underlying": underlying,
+      "governance": governance,
+      "liquidation": [{"balancer": [config.relatedTokens.aura, config.relatedTokens.wETH]}],
+      "strategyArgs": strategyArgs


This input won't be needed at all when all the relevant parameters are added to the strategy contract.

CryptJS13 · 2022-09-15T12:54:46Z

test/aura/stETH.js

+      "strategyArgs": strategyArgs
+    });
+
+    await strategy.setSellFloor(0, {from:governance});


Not needed, as the sellFloor is already 0 in the contract.

ryanycw · 2022-10-10T15:30:10Z

@CryptJS13 Thank you for your support and assistance, and sorry for the mess up here. I was trying to rename the branch with the pr. Here are the strategies for the top 6 pools.

The AuraStrategyJoinPoolUL is the original UL base contract inherited by the stETH, rETH, COMP, auraBAL Stable pools. And bbaUSD pool requires using batchSwap to get the underlying token, so I created an AuraStrategyBatchSwapUL. At last, the single asset auraBAL staking with Aura using the AuraStrategyAuraBAL base contract.

CryptJS13

A few comments. Really good work in general. Thanks!

CryptJS13 · 2022-10-20T11:04:20Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+    _setDepositArrayIndex(_depositArrayPosition);
+    _setBalancerPoolId(_balancerPoolID);
+    _setDepositToken(_depositToken);
+    setUint256(_HODL_RATIO_SLOT, 1000);


Seeing this now, not sure if the same problem is in the other bases, but we should set it with the value of _hodlRatio, not hardcode the value

Fixed. Thanks for the feedback! I saw this is the ConvexUL strategy, not sure if there is a reason that I am missing for the different implementation.

Hey, found this too, must have been a mistake on my side when working on the ConvexUL strategy

CryptJS13 · 2022-10-20T11:18:09Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+      address(this),
+      request
+    );
+


Would it be possible to implement something like this: https://github.com/harvest-finance/harvest-strategy/pull/71/files#diff-e96312f746bad02267da18daa9abef9d0f1b71c078c0888c02a4df5da415ba6bR254, here too. So check if we can swap the depositToken to the underlying for a better rate than depositing 1:1? Because almost always you get a 2-3% better result when buying auraBal in the market instead of depositing.

CryptJS13 · 2022-10-20T11:19:30Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+    IAuraBaseRewardPool(stakePool).stakeAll(); // Stake
+  }
+
+  function addRewardToken(address _token) 


I dont think this works. We can't add a reward token without also adding the liquidation info

It should look more like this: https://github.com/harvest-finance/harvest-strategy/blob/master/contracts/strategies/convex/base/ConvexStrategy4Token.sol#L196

But then adding the path and dexes to storedLiquidationPaths and storedLiquidationDexes

Fixed! Thank you for the suggestions. Indeed the original implementation won't liquidate the new reward token successfully.

CryptJS13 · 2022-10-20T11:30:56Z

contracts/strategies/aura/base/AuraStrategyBatchSwapUL.sol

+import "../../../base/interface/IVault.sol";
+import "../../../base/interface/balancer/IBVault.sol";
+
+contract AuraStrategyBatchSwapUL is 


Some of the comments from AuraStrategyAuraBAL are valid in this contract too.

ryanycw · 2022-11-06T18:55:09Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+    bytes32 swapPoolId = balancerSwapPoolId();
+
+    // Try to swap more than deposit
+    uint256 underlyingBefore = IERC20(underlyingToken).balanceOf(address(this));


@CryptJS13 Hi Jasper, this is how I implement the swapping option instead of direct deposit. My idea is that if I use queryBatchSwap, there might be a risk of having a sandwich attack. So I swap it with a limit. And if the swap succeeds, we will receive more underlying, otherwise, the swap doesn't proceed, and we receive nothing. Then we go with the deposit way.

I don't think there is a sandwich risk, as the quote and the swap happen within the same transaction. There is no way for someone to change the balances in the pool in between these actions.

I see, I have adjust it with querySwap before deposit. I was originally afraid if someone finds this transaction in the mempool, they can use the MEV bot to manipulate the price and thus affect the amount we get from the swap.

CryptJS13

Looking good! Left some small comments. Thanks for the work! :)

CryptJS13 · 2022-11-14T16:08:15Z

contracts/strategies/aura/AuraStrategyMainnet_COMP.sol

+pragma solidity 0.5.16;
+pragma experimental ABIEncoderV2;
+
+import "hardhat/console.sol";


This can be removed for production, from all other contracts too

CryptJS13 · 2022-11-14T16:10:35Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+    bytes32 swapPoolId = balancerSwapPoolId();
+
+    // Try to swap more than deposit
+    uint256 underlyingBefore = IERC20(underlyingToken).balanceOf(address(this));


I don't think there is a sandwich risk, as the quote and the swap happen within the same transaction. There is no way for someone to change the balances in the pool in between these actions.

CryptJS13 · 2022-11-14T16:15:57Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+  function addRewardToken(
+    address _token, 
+    address[] memory _path2Reward, 
+    bytes32 _dexOption


The dexes could be inputed as a list too, to generalise for tokens that would need to be liquidated using multiple dexes. This is the implementation I made for an updated version of the Convex strategy: https://github.com/harvest-finance/harvest-strategy/pull/77/files#diff-e91096217bcc49a83d27481a3ff62b6f23f59ab99b9ebae1edf466798d38754eR192

CryptJS13 · 2022-11-22T11:07:48Z

contracts/strategies/aura/base/AuraStrategyAuraBAL.sol

+pragma solidity 0.5.16;
+pragma experimental ABIEncoderV2;
+
+import "hardhat/console.sol";


Last little thing :) Please remove

Thank you for the reminder, just removed it.

ryanycw added 11 commits August 16, 2022 16:21

add setBytes32, getBytes32 to Upgradeable Storage

d08318e

ignore vscode settings

379618b

add balancer interfaces

0817ac8

add convex-like interfaces

c77de12

create strategy config parameters

58bbdf6

change file name

acfa954

change name of the booster and reward pool

3c4b123

create aura stETH strategy

45172a4

create balancer dex interface to add pool for swapping

1ac3564

update hardhat version

5f8d09d

test and configs for aura stETH strategy

b79697b

CryptJS13 reviewed Sep 15, 2022

View reviewed changes

ryanycw added 8 commits September 21, 2022 13:42

making adjustment to PR#76

73d535f

base contract using batchSwap for Bpt

d0e47f8

base contract using joinPool for Bpt

2b8a35b

base contract for auraBal

af22576

strategy contract of the top 6 pools

bde57db

ul general test functions

0d3d8f8

test for strategies of top 6 pools

2abead6

configs for test scripts

cba794a

ryanycw changed the title ~~Aura stETH Strategy~~ Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) Oct 10, 2022

ryanycw closed this Oct 10, 2022

ryanycw deleted the aura_stETHStrategy branch October 10, 2022 15:01

ryanycw restored the aura_stETHStrategy branch October 10, 2022 15:03

ryanycw reopened this Oct 10, 2022

ryanycw closed this Oct 10, 2022

ryanycw deleted the aura_stETHStrategy branch October 10, 2022 15:09

ryanycw restored the aura_stETHStrategy branch October 10, 2022 15:10

ryanycw reopened this Oct 10, 2022

CryptJS13 reviewed Oct 20, 2022

View reviewed changes

ryanycw added 4 commits November 7, 2022 02:45

whale change

8a1071c

adjust add reward token and add common variables

b67a139

move common variables to base

36b06d8

add swap option in convert to auraBAL

0f0f587

ryanycw commented Nov 6, 2022

View reviewed changes

CryptJS13 reviewed Nov 14, 2022

View reviewed changes

ryanycw added 6 commits November 16, 2022 23:06

remove hardhat console import

f8e45bc

update add reward token

4feaf24

update AuraBAL strategy - querySwap before deposit

1a90601

create documentation of aura strategies

45654a9

new strategy for stETHbbaUSD pool

184cb72

test and configs for stETHbbaUSD strategy

15afc0d

CryptJS13 reviewed Nov 22, 2022

View reviewed changes

remove unuse import

bf1c462

CryptJS13 mentioned this pull request Mar 2, 2023

Add aura idle #80

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) #76

Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) #76

ryanycw commented Sep 14, 2022 •

edited

Loading

ryanycw commented Sep 14, 2022

CryptJS13 left a comment

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

CryptJS13 Sep 15, 2022

ryanycw commented Oct 10, 2022 •

edited

Loading

CryptJS13 left a comment

CryptJS13 Oct 20, 2022

ryanycw Nov 5, 2022

CryptJS13 Nov 14, 2022

CryptJS13 Oct 20, 2022

CryptJS13 Oct 20, 2022

CryptJS13 Oct 20, 2022

ryanycw Nov 6, 2022

CryptJS13 Oct 20, 2022

ryanycw Nov 6, 2022

CryptJS13 Nov 14, 2022

ryanycw Nov 16, 2022

CryptJS13 left a comment

CryptJS13 Nov 14, 2022

CryptJS13 Nov 14, 2022

CryptJS13 Nov 14, 2022

CryptJS13 Nov 22, 2022

ryanycw Nov 22, 2022


		import "./base/AuraStrategyUL.sol";

		contract AuraStrategystETH is AuraStrategyUL {

Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) #76

Are you sure you want to change the base?

Aura Strategies of Top 6 Pools (auraBAL, auraBAL Stable, wstETH, bbaUSD, rETH, COMP) #76

Conversation

ryanycw commented Sep 14, 2022 • edited Loading

ryanycw commented Sep 14, 2022

CryptJS13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanycw commented Oct 10, 2022 • edited Loading

CryptJS13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CryptJS13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanycw commented Sep 14, 2022 •

edited

Loading

ryanycw commented Oct 10, 2022 •

edited

Loading