VM Maintenance Strategy

[torchiaf]

Summary

PR Checklist

• Is this a multi-tenancy feature/bug?
  • Yes, the relevant RBAC changes are at:
• Do we need to backport changes to the old Rancher UI, such as RKE1?
  • Yes, the relevant PR is at:
• Are backend engineers aware of UI changes?
  • Yes, the backend owner is:

Related Issue harvester/harvester#5888

Occurred changes and/or fixed issues

Technical notes summary

• Instance Labels and Advanced Options tabs have been rearranged to a different position; Advanced tab is now at the bottom of the list of VM tabs.
• It adds the dropdown element to select the Maintenance Strategy label.
• The label is excluded from Instance Labels tab

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

[votdev]

Please check the HEP for more information about how the strategies are named.

[votdev]

There are several issues that need to be adapted.

[torchiaf]

Thanks @votdev ; I've updated the label's values and changed the YAML field where it is saved -> metadata.labels .

[votdev]

LGTM in general. The solution to add a drop-down in the Advances Options tab is a nice idea.

I would suggest to add a comment to the commit + PR message that the Instance Labels tab has been rearranged to a different position and that the Advanced Options is now at the last position. This makes it easier to review the code.

[torchiaf]

@mergify backport release-harvester-v1.4

[mergify]

backport release-harvester-v1.4

✅ Backports have been created

• #1071 VM Maintenance Strategy (backport #1060) has been created for branch release-harvester-v1.4