fix API token data not refresh issue #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
commented
Dec 3, 2024
| @@ -746,6 +746,11 @@ export const actions = { | |||
| const isRancherInHarvester = (rancherManagerSupport?.value || rancherManagerSupport?.default) === 'true'; | |||
|
|
|||
| commit('isRancherInHarvester', isRancherInHarvester); | |||
| // standalone harvester cluster needs to subscribe rancher socket to get latest token data update | |||
There was a problem hiding this comment.
Not sure there has better place to do rancher/subscribe or do single token subscription.
a110605
added
Backport to v1.3
a110605
added
Require backport v1.3
Yu-Jack
approved these changes
Dec 5, 2024
torchiaf
approved these changes
Dec 6, 2024
This was referenced Dec 9, 2024
a110605
added a commit
that referenced
this pull request
Dec 10, 2024
…v1.4/pr-1236 fix API token data not refresh issue (backport #1236)
a110605
added a commit
that referenced
this pull request
Dec 10, 2024
…v1.3/pr-1236 fix API token data not refresh issue (backport #1236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix API token data not refresh in standalone harvester.
Standalone harvester doesn't have websocket connect to
/v3/token. While rancher dashboard have dispatch rancher/subscribe.PR Checklist
Related Issue #
harvester/harvester#6841
Backend PR : harvester/harvester#7076
Note. this PR needs to open in rancher/dashboard to fix the same issue on harvester-ui-extension.
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Screen.Recording.2024-12-03.at.4.15.32.PM.mov