Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port AppModal component to harvester source code #1249

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Dec 30, 2024

Summary

Previous PR port AppModal component from Rancher/shell to harvester shell. But the appModal was introduced after Rancher 2.9+ which causes it doesn't exist on Rancher 2.8.

This PR port AppModal component to harvester source code.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#7147

Screenshot/Video

1. Import harvester into Rancher 2.8 or 2.9
2. Pull this PR locally and run `yarn build-pkg harvester && yarn serve-pkgs`
3. Change 
   - ui-plugin-index setting to http://127.0.0.1:4500/harvester-1.4.0/harvester-1.4.0.umd.min.js
   - ui-source to external
4. Refresh

Test on Rancher 2.9

2.9.2.mov

Test on Rancher 2.8

2.8.5.mov

@a110605 a110605 requested a review from torchiaf December 30, 2024 02:58
@a110605 a110605 self-assigned this Dec 30, 2024
@a110605 a110605 added Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4 labels Dec 30, 2024

<template>
<mounting-portal
mountTo="#__layout"
Copy link
Collaborator Author

@a110605 a110605 Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original mountTo is id=modals , but on Rancher 2.8, there is no id=modals in DOM. ( Because it's introduced via shell/public/index.html

Change mounTo #__layout seems no harm

Screenshot 2024-12-28 at 11 16 47 AM

@a110605 a110605 requested a review from houhoucoop December 30, 2024 03:49
Copy link

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 9994e47 into harvester:master Jan 2, 2025
12 checks passed
bk201 added a commit that referenced this pull request Jan 2, 2025
…v1.4/pr-1249

fix: port AppModal component to harvester source code (backport #1249)
bk201 added a commit that referenced this pull request Jan 2, 2025
…v1.3/pr-1249

fix: port AppModal component to harvester source code (backport #1249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants