Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upgrade free space check to document #332

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

w13915984028
Copy link
Member

issue:
harvester/harvester#4052

The upgrade will check free disk space in each node and deny if not met. User may customize the limitation.

original issue and PR:
harvester/harvester#2935
harvester/harvester#3700

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 092d130
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/649d2f999b706e000823a3d2
😎 Deploy Preview https://deploy-preview-332--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/upgrade/automatic.md Outdated Show resolved Hide resolved
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

docs/upgrade/automatic.md Outdated Show resolved Hide resolved
docs/upgrade/automatic.md Outdated Show resolved Hide resolved
docs/upgrade/automatic.md Outdated Show resolved Hide resolved
docs/upgrade/automatic.md Outdated Show resolved Hide resolved
docs/upgrade/automatic.md Outdated Show resolved Hide resolved
@w13915984028
Copy link
Member Author

@LucasSaintarbor @bk201

I changed the free space to free system disk space, it should be more precise.

please take a further look, thanks.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to add the "Caution" note line 148. LGTM 👍

docs/upgrade/automatic.md Show resolved Hide resolved
@vickyhella vickyhella merged commit 64d5f33 into harvester:main Jul 4, 2023
5 checks passed
@w13915984028 w13915984028 deleted the doc4052 branch July 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants