Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add steps to deploying to the RKE2 custom cluster #525
feat: add steps to deploying to the RKE2 custom cluster #525
Changes from 12 commits
b89f0ab
ee028f8
8ff2dee
834d784
0b14a97
63a318a
172b9be
59abebf
5ff1fa5
f0c5440
19916c5
729e5c8
7a26ae2
ccbc8e2
db49d78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the doc preview, the ordered list starts with
1.
again. I'm not sure if the intention is to continue with3.
. And we should mention here the user should go to the Rancher's GUI, but not Harvester's GUI anymore.Please also add the doc source to v1.3/v1.2 versions if needed (it's currently only in the dev version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it and also migrated the document to v1.3/v1.2. Thanks.