-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add steps to deploying to the RKE2 custom cluster #525
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b89f0ab
feat: add steps to deploying to the RKE2 custom cluster
FrankYang0529 ee028f8
Update docs/rancher/cloud-provider.md
FrankYang0529 8ff2dee
Update docs/rancher/cloud-provider.md
FrankYang0529 834d784
Update docs/rancher/cloud-provider.md
FrankYang0529 0b14a97
Update docs/rancher/cloud-provider.md
FrankYang0529 63a318a
Update docs/rancher/cloud-provider.md
FrankYang0529 172b9be
Update docs/rancher/cloud-provider.md
FrankYang0529 59abebf
refactor: move note close to step title
FrankYang0529 5ff1fa5
Update docs/rancher/cloud-provider.md
FrankYang0529 f0c5440
Update docs/rancher/cloud-provider.md
FrankYang0529 19916c5
Update docs/rancher/cloud-provider.md
FrankYang0529 729e5c8
Update docs/rancher/cloud-provider.md
FrankYang0529 7a26ae2
fix: fix note block
FrankYang0529 ccbc8e2
fix: fix list number
FrankYang0529 db49d78
feat: backport rke2 custom cluster to v1.2, v1.3
FrankYang0529 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the doc preview, the ordered list starts with
1.
again. I'm not sure if the intention is to continue with3.
. And we should mention here the user should go to the Rancher's GUI, but not Harvester's GUI anymore.Please also add the doc source to v1.3/v1.2 versions if needed (it's currently only in the dev version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it and also migrated the document to v1.3/v1.2. Thanks.